New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OnAllRemovedFromWorld only triggering once #15680
Conversation
29f3676
to
4799c97
Compare
Rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM, just one minor nit.
Can you please provide a testcase that demonstrates the bug and fix?
Ping @abcdefg30 |
4799c97
to
715a65a
Compare
Do you have a testcase that demonstrates the bug and fix? |
Deferring to Next + 1 so this won't hold up the playtest. We can pull this back if someone can provide a testcase so we can merge this in time. |
Testcase: Replace
You won't have do anything other than watching for the message "Retreat is not an option!". It should only appear once one Tanya and both rifles are inside the transport. (On bleed you will see the message with only the two rifles inside the transport but both Tanyas outside.) |
715a65a
to
cfdf191
Compare
Thanks, LGTM. |
We trigger all the other triggers like
OnRemovedFromWorld
multiple times, except the "on killed" ones (obviously) and the "on captured" triggers (I could fix those as well, we usually don't need this however).