Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence some doc errors in VS2019. #16716

Merged
merged 1 commit into from Jun 21, 2019
Merged

Conversation

RoosterDragon
Copy link
Member

Needed to suppress some style rules which VS2019 is reporting as errors. Fixed rules with only one or two breakages and suppressed the rest.

(I figure this must be VS specific or it would've otherwise been noted by now...)

Copy link
Member

@pchote pchote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and confirmed that nothing changes when compiled using Rider or make check on macOS.

@pchote pchote added this to the Next Release milestone Jun 20, 2019
@teinarss teinarss mentioned this pull request Jun 20, 2019
@reaperrr reaperrr merged commit 58dced7 into OpenRA:bleed Jun 21, 2019
@RoosterDragon RoosterDragon deleted the fix-doc-style branch June 23, 2019 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants